Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump worklfow deps #2233

Merged
merged 1 commit into from
Jul 8, 2024
Merged

chore: bump worklfow deps #2233

merged 1 commit into from
Jul 8, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented Jul 5, 2024

Description

This PR bumps dependencies used in workflows to the latest versions

In most cases bump to v3 means that the Node runtime is updated from 12 to 16 and bump to v4 means it's updated to 20.

Additional changes are not affecting our workflows and are as follows:

  • actions/setup-node@v3 changed flag name from version to node-version
  • actions/cache@v4 added a new flag save-always
  • actions/upload-artifact@v4 changed how operating on multiple files works: migration docs

Changes

Test code and steps to reproduce

Checklist

  • Ensured that CI passes

@alduzy alduzy marked this pull request as ready for review July 5, 2024 14:09
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess it'll work. Please note however that you are changing major version of dependencies -> please take a look at respective changelogs & check out what are the breaking changes of each dependency you changed. After you've done that we can merge.

@alduzy
Copy link
Member Author

alduzy commented Jul 8, 2024

@kkafar I've updated the PR's description.

@alduzy alduzy requested a review from kkafar July 8, 2024 10:34
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alduzy alduzy merged commit 546e72f into main Jul 8, 2024
7 checks passed
@alduzy alduzy deleted the @alduzy/bump-workflow-deps branch July 8, 2024 13:31
alduzy added a commit that referenced this pull request Jul 9, 2024
## Description

This PR bumps dependencies used in workflows to the latest versions

In most cases bump to v3 means that the Node runtime is updated from 12
to 16 and bump to v4 means it's updated to 20.

Additional changes are not affecting our workflows and are as follows:
- actions/setup-node@v3 changed flag name from `version` to
`node-version`
- actions/cache@v4 added a new flag `save-always`
- actions/upload-artifact@v4 changed how operating on multiple files
works: [migration
docs](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md)

## Changes

<!--
Please describe things you've changed here, make a **high level**
overview, if change is simple you can omit this section.

For example:

- Updated `about.md` docs

-->

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [x] Ensured that CI passes
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

This PR bumps dependencies used in workflows to the latest versions

In most cases bump to v3 means that the Node runtime is updated from 12
to 16 and bump to v4 means it's updated to 20.

Additional changes are not affecting our workflows and are as follows:
- actions/setup-node@v3 changed flag name from `version` to
`node-version`
- actions/cache@v4 added a new flag `save-always`
- actions/upload-artifact@v4 changed how operating on multiple files
works: [migration
docs](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md)

## Changes

<!--
Please describe things you've changed here, make a **high level**
overview, if change is simple you can omit this section.

For example:

- Updated `about.md` docs

-->

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants